Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disconnect TrieMap from java.util.AbstractMap #144

Open
rovarga opened this issue Apr 13, 2023 · 0 comments
Open

Disconnect TrieMap from java.util.AbstractMap #144

rovarga opened this issue Apr 13, 2023 · 0 comments

Comments

@rovarga
Copy link
Collaborator

rovarga commented Apr 13, 2023

TrieMap is a fully-fledged implementation, overriding pretty much all methods provided by AbstractMap. Furthermore, unlike ConcurrentHashMap, we do not have access to our keySet field, leading to us duplicating it.

Do not extend AbstractMap, implementing all ConcurrentHashMap methods explicitly. Things like hashCode(), equals() and toString() can nicely be implemented in ImmutableTrieMap and having MutableTrieMap create a snapshot and delegate to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant