-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Milestone 1 Review #36
Comments
@mohamad-amin Hey, thank you for the feedback. It is really helpful. I think your idea is very clear. Just one question, I am not sure if I understand this word clearly. |
Hey, sorry isn't your problem inherently a regression problem? (Ramens' rating) |
Yeah, finally we changed it into a binary classification. Maybe we can state it more clearly in the summary |
Hi @mohamad-amin! Re: Comment 5: Pandas-profiling does not render in the ipynb file and only exports in HTML and JSON. Pandas-profiling to_file documentation. I understand it's not ideal, as the HTML does not render in github because it's interactive, but the file is easily downloadable and you can open it in browser. It doesn't print nicely to PDF either because we considered uploading the PDF of the EDA as well. What would be your recommendation for rendering pandas-profiling reports? |
Good job! Here are my feedbacks for milestone 1 assessment.
You might need to pay more attention to these parts:
Exploratory data analysis in a literate code document: VIZ
Have you looked into the HTML report file that you have provided? It's not really opening on github. First, your report should be openable on github so that everyone could see this. Second, you don't need to convert it to HTML. That's why it breaks. Please do not convert your notebooks to HTML files again.
Exploratory data analysis in a literate code document: QUALITY
The text was updated successfully, but these errors were encountered: