Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sanity check not acted upon #16

Open
VitaliiAndreev opened this issue Feb 6, 2022 · 2 comments
Open

Sanity check not acted upon #16

VitaliiAndreev opened this issue Feb 6, 2022 · 2 comments

Comments

@VitaliiAndreev
Copy link

Oi oi. Check out Diplomacy.ForcedWarPeaceBehaviour.GetDiplomacyFromValidClans(). You seem to be still trying to look for a clan when you know it's not there. Is that an oversight or intended behavior? C:

image

@JoeFwd
Copy link
Collaborator

JoeFwd commented Feb 6, 2022

Hello, it is indeed an unintented behaviour. Good catch !
Adding the continue statement will be good enough.

@VitaliiAndreev
Copy link
Author

Ye, that's what I ended up doing in my manual hotfix. C:
Can't push a new branch to this repo though.

In relation to this, I've also opted to remove exception throwing in SetWarIfPossible() because it looks like that case shouldn't be fatal. I haven't been digging into the code to determine if it has consequences further down, but it looks like it could just be logged as a warning and ignored instead of crashing the whole thing. C:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants