Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

global/regional beneficiaries #62

Open
doug-leasure opened this issue Jan 12, 2024 · 4 comments · May be fixed by #73
Open

global/regional beneficiaries #62

doug-leasure opened this issue Jan 12, 2024 · 4 comments · May be fixed by #73
Assignees
Labels
enhancement New feature or request

Comments

@doug-leasure
Copy link
Member

doug-leasure commented Jan 12, 2024

The global and regional beneficiary tags that many impact case studies used are obscuring research that focused on an individual country versus research that included a country because it had global impact. We want to add a section to the Settings menu to allow users to toggle between these different types of impact to use when selecting countries form the Impact Beneficiaries map.

New settings menu section (showing default setting)...


Definition of a "beneficiary country":
[ X ] Country-specific (country a beneficiary only if Impact Case Study explicitly listed it)
[ X ] Union tags (country a beneficiary if Impact Case Study listed the union it belongs to; e.g. European Union)
[ ] Region tag (country a beneficiary if Impact Case Study listed the region it belongs to; e.g. Global, Africa, etc.)

@doug-leasure doug-leasure added the enhancement New feature or request label Jan 12, 2024
@doug-leasure
Copy link
Member Author

@GISRedeDev , there are two columns in the main ICS table that will really help with this: region_extracted and union_extracted

@GISRedeDev
Copy link
Collaborator

  • Block users from unselecting all country parameters
  • Check that topics are being filtered correctly (by country parameter)
  • Check other panels are being filtered correctly by country parameter

@doug-leasure
Copy link
Member Author

@GISRedeDev , the functionality in branch 62-globalregional-beneficiaries appears to be working correctly.

If you change the setting, I noticed that the popup on-hover in the beneficiaries map does not seem to update with the correct beneficiaries count until after you have clicked on a country to filter by beneficiary. Is this avoidable?

For example, with the default behaviour Democratic Republic of Congo (COD) has 269 beneficiaries. When you change the setting to only "Country" (i.e. include countries as a beneficiary only if they are explicitly named), the beneficiary count for COD decreases to 57 as expected, but the pop-up in the beneficiary map says 269 until after you click on COD. When you click on COD it looks like the pop-up beneficiary counts are then correct for all countries.

@doug-leasure
Copy link
Member Author

@GISRedeDev, is it possible to allow a country with zero beneficiaries to still be selectable? For example, select Libya and then there are many countries with zero beneficiaries that can no longer be selected. This is not critical because it is possible to refresh the beneficiaries and then select a new country, but it would be smoother if the countries with zero beneficiaries could still be selected.

Please let me know how much work this would require.

@GISRedeDev GISRedeDev linked a pull request Feb 17, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants