From f561dea56db6413d806149fd1a23fa244093f9c8 Mon Sep 17 00:00:00 2001 From: oxcom Date: Thu, 11 Oct 2018 14:21:33 +0200 Subject: [PATCH 1/2] remove \Symfony\Component\Debug\Exception\FatalErrorException from default configuration --- DependencyInjection/Configuration.php | 1 - README.md | 1 - Resources/doc/configuration.rst | 3 +-- 3 files changed, 1 insertion(+), 4 deletions(-) diff --git a/DependencyInjection/Configuration.php b/DependencyInjection/Configuration.php index 35ec734..b42b1b4 100755 --- a/DependencyInjection/Configuration.php +++ b/DependencyInjection/Configuration.php @@ -54,7 +54,6 @@ class Configuration implements ConfigurationInterface * @var array */ public static $exclude = [ - '\Symfony\Component\Debug\Exception\FatalErrorException', ]; /** diff --git a/README.md b/README.md index a9e7a59..a2aa68d 100755 --- a/README.md +++ b/README.md @@ -19,7 +19,6 @@ More documentation here [here](https://github.com/OxCom/symfony-rollbar-bundle/t symfony_rollbar: enable: true exclude: - - \Symfony\Component\Debug\Exception\FatalErrorException - \AppBundle\Exceptions\MyAwesomeException rollbar: access_token: 'some-secret-token-here' diff --git a/Resources/doc/configuration.rst b/Resources/doc/configuration.rst index c746ff9..1002c4c 100755 --- a/Resources/doc/configuration.rst +++ b/Resources/doc/configuration.rst @@ -7,8 +7,7 @@ Simple configuration of bundle: symfony_rollbar: enable: true - exclude: - - \Symfony\Component\Debug\Exception\FatalErrorException + exclude: [] rollbar: access_token: 'some-secret-token-here' environment: '%kernel.environment%' From 48e8f362a099ca0d83752e79019213ca8dbcc709 Mon Sep 17 00:00:00 2001 From: oxcom Date: Thu, 11 Oct 2018 14:25:25 +0200 Subject: [PATCH 2/2] update tests --- .../DependencyInjection/ConfigurationTest.php | 1 + 1 file changed, 1 insertion(+) diff --git a/Tests/SymfonyRollbarBundle/DependencyInjection/ConfigurationTest.php b/Tests/SymfonyRollbarBundle/DependencyInjection/ConfigurationTest.php index 74850cf..b44a77b 100755 --- a/Tests/SymfonyRollbarBundle/DependencyInjection/ConfigurationTest.php +++ b/Tests/SymfonyRollbarBundle/DependencyInjection/ConfigurationTest.php @@ -22,6 +22,7 @@ public function testParameters() $defaultErrorMask = E_ERROR | E_WARNING | E_PARSE | E_CORE_ERROR | E_USER_ERROR | E_RECOVERABLE_ERROR; $exclude = Configuration::$exclude; + $exclude[] = '\Symfony\Component\Debug\Exception\FatalErrorException'; $exclude[] = '\SymfonyRollbarBundle\Tests\Fixtures\MyAwesomeException'; $exclude[] = '\ParseError'; $exclude[] = '\Symfony\Component\HttpKernel\Exception\HttpExceptionInterface';