Various typing and signature fixes #2018
Merged
+57
−50
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist:
number
) and pull request (:pull:number
) has been addedWhat kind of change does this PR introduce?
hot_spell_max_magnitude
to removeop
.mbcn_adjust
to precisely report that DataArrays are expected and Dataset is returned.Does this PR introduce a breaking change?
Yes.
hot_spell_max_magnitude
previously accepted anop
argument that was unused in the algorithm. This has been removed.Other information:
There is much more work to be done, but many changes require significant refactors. There's enough in the current release to justify stopping here for now.