Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various typing and signature fixes #2018

Merged
merged 5 commits into from
Dec 11, 2024
Merged

Various typing and signature fixes #2018

merged 5 commits into from
Dec 11, 2024

Conversation

Zeitsperre
Copy link
Collaborator

@Zeitsperre Zeitsperre commented Dec 10, 2024

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
    • This PR fixes #xyz
  • Tests for the changes have been added (for bug fixes / features)
    • (If applicable) Documentation has been added / updated (for bug fixes / features)
  • CHANGELOG.rst has been updated (with summary of main changes)
    • Link to issue (:issue:number) and pull request (:pull:number) has been added

What kind of change does this PR introduce?

  • Addresses a few typing errors.
  • Fixes a few overwritten variables in doctests.
  • Fixes the call signature of hot_spell_max_magnitude to remove op.
  • Fixes the call signature of mbcn_adjust to precisely report that DataArrays are expected and Dataset is returned.

Does this PR introduce a breaking change?

Yes. hot_spell_max_magnitude previously accepted an op argument that was unused in the algorithm. This has been removed.

Other information:

There is much more work to be done, but many changes require significant refactors. There's enough in the current release to justify stopping here for now.

Sorry, something went wrong.

@Zeitsperre Zeitsperre added the priority Immediate priority label Dec 10, 2024
@Zeitsperre Zeitsperre added this to the v0.54.0 milestone Dec 10, 2024
@Zeitsperre Zeitsperre self-assigned this Dec 10, 2024
@github-actions github-actions bot added sdba Issues concerning the sdba submodule. docs Improvements to documenation indicators Climate indices and indicators labels Dec 10, 2024
@github-actions github-actions bot added the approved Approved for additional tests label Dec 10, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@Zeitsperre Zeitsperre merged commit 4b4ae51 into main Dec 11, 2024
21 checks passed
@Zeitsperre Zeitsperre deleted the security-fixes branch December 11, 2024 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Approved for additional tests docs Improvements to documenation indicators Climate indices and indicators priority Immediate priority sdba Issues concerning the sdba submodule.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants