From 136a4cc7a22aa893650267e08d61d660e097d6e7 Mon Sep 17 00:00:00 2001 From: Trevor James Smith <10819524+Zeitsperre@users.noreply.github.com> Date: Tue, 10 Dec 2024 13:22:34 -0500 Subject: [PATCH 1/2] handle exceptionally rare error --- CHANGELOG.rst | 1 + tests/test_sdba/test_loess.py | 11 ++++++++++- 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.rst b/CHANGELOG.rst index 689ed2303..fbebc27cc 100644 --- a/CHANGELOG.rst +++ b/CHANGELOG.rst @@ -33,6 +33,7 @@ Internal changes * The `numpydoc` linting tool has been added to the development dependencies, linting checks, and the `pre-commit` configuration. (:pull:`1988`). * `xclim` now uses a `src` layout for the codebase. Structure-dependent functions, documentation, and build commands have been adapted to reflect these changes. (:pull:`1971`). * Added a more robust `yamllint` configuration to ensure that all YAML files are linted consistently. (:pull:`1971`). +* Addressed a very rare singular matrix error that can happen in ``test_loess_smoothing_nan``. CI changes ^^^^^^^^^^ diff --git a/tests/test_sdba/test_loess.py b/tests/test_sdba/test_loess.py index 7fe607cd3..fb802f3fa 100644 --- a/tests/test_sdba/test_loess.py +++ b/tests/test_sdba/test_loess.py @@ -1,5 +1,7 @@ from __future__ import annotations +import logging + import numpy as np import pandas as pd import pytest @@ -84,4 +86,11 @@ def test_loess_smoothing_nan(use_dask): assert out.dims == da.dims # check that the output is all nan on the axis with nan in the input - assert np.isnan(out.values[0, 0]).all() + try: + assert np.isnan(out.values[0, 0]).all() + except np.linalg.LinAlgError: + msg = ( + "This has roughly a 1/50,000,000 chance of occurring. Buy a lottery ticket!" + ) + logging.error(msg) + pass From 30604393478df939cfdd7856bc8fc7d3907be72e Mon Sep 17 00:00:00 2001 From: Trevor James Smith <10819524+Zeitsperre@users.noreply.github.com> Date: Tue, 10 Dec 2024 13:44:32 -0500 Subject: [PATCH 2/2] update CHANGELOG.rst --- CHANGELOG.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.rst b/CHANGELOG.rst index fbebc27cc..ffd7ab3fb 100644 --- a/CHANGELOG.rst +++ b/CHANGELOG.rst @@ -33,7 +33,7 @@ Internal changes * The `numpydoc` linting tool has been added to the development dependencies, linting checks, and the `pre-commit` configuration. (:pull:`1988`). * `xclim` now uses a `src` layout for the codebase. Structure-dependent functions, documentation, and build commands have been adapted to reflect these changes. (:pull:`1971`). * Added a more robust `yamllint` configuration to ensure that all YAML files are linted consistently. (:pull:`1971`). -* Addressed a very rare singular matrix error that can happen in ``test_loess_smoothing_nan``. +* Addressed a very rare singular matrix error that can happen in ``test_loess_smoothing_nan``. (:pull:`2015`). CI changes ^^^^^^^^^^