Using map groups in MBCn #1951
Open
Using map groups in MBCn #1951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coxipi
commented
Oct 11, 2024
Comment on lines
+1870
to
+1874
| af_q[group.prop] = times.times.values | ||
| af_q = af_q.rename({group.prop: "time"}) | ||
| af_q = af_q.broadcast_like(hist) | ||
| # a bit dirty, should avoid this situation before | ||
| af_q = af_q.chunk({"time": -1}) |
There was a problem hiding this comment.
this is a hack: broadcast PROP dimension of af_q to the the full time dimension, so it can be used in map_groups. Perhaps there is already a built-in way to achieve this?
coxipi
commented
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist:
number) and pull request (:pull:number) has been addedWhat kind of change does this PR introduce?
Does this PR introduce a breaking change?
No
Other information:
I need to do further tests, but so far it seems as fast, if not faster, than the old implementation. But I have to make tests with bigger datasets.
I tried using the old way, only for training, for a dataset with resolution of 0.11deg over NAM. And the memory was busting, I think there was probably a memory leak in the old way, so that was my motivation to try again to use map_groups, rather than being focused solely on performance.