add missing robustness functions in docs #1630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zeitsperre
approved these changes
Jan 29, 2024
|
@juliettelavoie Think you could tackle the formatting here?
|
juliettelavoie
commented
Jan 29, 2024
| @@ -116,8 +118,6 @@ def robustness_fractions( # noqa: C901 | |||
| | Negative change | (cf - cpf) | 1 - pf - (cf -cpf) | 1 - pf | | |||
| +-----------------+--------------------+------------------------+------------+ | |||
|
|
|||
| Notes | |||
| ----- | |||
| Available statistical tests are : | |||
|
|
|||
| {tests_doc} | |||
There was a problem hiding this comment.
are some tests missing on purpose @aulemahal ? I see ipcc-ar6-c in the example notebook but I can't find it in the code?
There was a problem hiding this comment.
Woups, the automatic tests doc generation was done on the wrong method. I think I came up with the mechanism before changing the function name.
juliettelavoie
commented
Jan 29, 2024
|
Hmm, indeed, the module's header is a bit outdated. suggestion: This submodule is inspired by and tries to follow the guidelines of the IPCC, more specifically :cite:p:`collins_long-term_2013` (AR5) and :cite:cts:`ipccatlas_ar6wg1` (AR6). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist:
number) and pull request (:pull:number) has been addedWhat kind of change does this PR introduce?
Does this PR introduce a breaking change?
Other information: