Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deps to add yamale #1596

Merged
merged 6 commits into from
Jan 15, 2024
Merged

Update deps to add yamale #1596

merged 6 commits into from
Jan 15, 2024

Conversation

Zeitsperre
Copy link
Collaborator

@Zeitsperre Zeitsperre commented Jan 15, 2024

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
  • Tests for the changes have been added (for bug fixes / features)
    • (If applicable) Documentation has been added / updated (for bug fixes / features)
  • CHANGES.rst has been updated (with summary of main changes)
    • Link to issue (:issue:number) and pull request (:pull:number) has been added

What kind of change does this PR introduce?

  • Adds yamale to the core dependencies

Does this PR introduce a breaking change?

Yes, dependencies have changed.

Other information:

yamale code can be found in the core of the library. It might be a good idea to perform an analysis of all existing deps to ensure that the necessary entries are all listed.

@Zeitsperre Zeitsperre added the bug Something isn't working label Jan 15, 2024
@Zeitsperre Zeitsperre added this to the v0.48.0 milestone Jan 15, 2024
@Zeitsperre Zeitsperre self-assigned this Jan 15, 2024
@github-actions github-actions bot added the approved Approved for additional tests label Jan 15, 2024
@github-actions github-actions bot added the CI Automation and Contiunous Integration label Jan 15, 2024
Copy link

Note
It appears that this Pull Request modifies the main.yml workflow.

On inspection, the XCLIM_TESTDATA_BRANCH environment variable is set to the most recent tag (v2023.12.14).

No further action is required.

@coveralls
Copy link

Coverage Status

coverage: 90.273%. remained the same
when pulling 444eee3 on update-deps
into 07150a7 on master.

@Zeitsperre Zeitsperre merged commit bcec43e into master Jan 15, 2024
17 checks passed
@Zeitsperre Zeitsperre deleted the update-deps branch January 15, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Approved for additional tests bug Something isn't working CI Automation and Contiunous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Yamale error validating data with schema for xscen conversion
3 participants