Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix discussion templates #1592

Merged
merged 2 commits into from
Jan 15, 2024
Merged

Fix discussion templates #1592

merged 2 commits into from
Jan 15, 2024

Conversation

Zeitsperre
Copy link
Collaborator

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
    • This PR fixes #xyz
  • Tests for the changes have been added (for bug fixes / features)
    • (If applicable) Documentation has been added / updated (for bug fixes / features)
  • CHANGES.rst has been updated (with summary of main changes)
    • Link to issue (:issue:number) and pull request (:pull:number) has been added

What kind of change does this PR introduce?

  • The discussion templates were badly-formed. This hopefully fixes them.

Does this PR introduce a breaking change?

No.

Other information:

https://docs.github.com/en/discussions/managing-discussions-for-your-community/syntax-for-discussion-category-forms

@Zeitsperre Zeitsperre requested a review from aulemahal January 12, 2024 20:50
@Zeitsperre Zeitsperre self-assigned this Jan 12, 2024
@Zeitsperre Zeitsperre added the docs Improvements to documenation label Jan 12, 2024
aulemahal
aulemahal approved these changes Jan 12, 2024
View reviewed changes
Copy link
Collaborator

@aulemahal aulemahal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I guess the only way to know if it works is to merge ?

@github-actions github-actions bot added the approved Approved for additional tests label Jan 12, 2024
@coveralls
Copy link

Coverage Status

coverage: 90.284% (+0.01%) from 90.273%
when pulling 6205070 on update-discussions
into 07150a7 on master.

@Zeitsperre Zeitsperre merged commit 280db31 into master Jan 15, 2024
23 checks passed
@Zeitsperre Zeitsperre deleted the update-discussions branch January 15, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aulemahal aulemahal aulemahal approved these changes

Assignees

@Zeitsperre Zeitsperre

Labels
approved Approved for additional tests docs Improvements to documenation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Zeitsperre @coveralls @aulemahal