Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing missing=0 in convert calendar #1563

Merged
merged 1 commit into from
Dec 15, 2023
Merged

Fixing missing=0 in convert calendar #1563

merged 1 commit into from
Dec 15, 2023

Conversation

aulemahal
Copy link
Collaborator

Pull Request Checklist:

What kind of change does this PR introduce?

  • When missing=0 is passed to convert_calendar, it is used instead of replaced by np.NaN by faulty expression.

Does this PR introduce a breaking change?

No.

Other information:

Xarray's implementation does not have this problem.

@aulemahal aulemahal requested a review from tlogan2000 December 15, 2023 18:49
@github-actions github-actions bot added the approved Approved for additional tests label Dec 15, 2023
@aulemahal aulemahal merged commit 2122dba into master Dec 15, 2023
25 of 26 checks passed
@aulemahal aulemahal deleted the fix-convcal-miss0 branch December 15, 2023 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Approved for additional tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert_calendar bugs with falsy missing value.
2 participants