Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include indicator ID in searched terms. #1528

Merged
merged 3 commits into from
Nov 29, 2023
Merged

Include indicator ID in searched terms. #1528

merged 3 commits into from
Nov 29, 2023

Conversation

huard
Copy link
Collaborator

@huard huard commented Nov 14, 2023 •
edited by Zeitsperre
Loading

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
  • Tests for the changes have been added (for bug fixes / features)
    • (If applicable) Documentation has been added / updated (for bug fixes / features)
  • CHANGES.rst has been updated (with summary of main changes)
    • Link to issue (:issue:number) and pull request (:pull:number) has been added

What kind of change does this PR introduce?

  • In the RtD, indicator search now searches through the indicator IDs.

Does this PR introduce a breaking change?

Other information:

@github-actions github-actions bot added the docs Improvements to documenation label Nov 14, 2023
Zeitsperre
Zeitsperre approved these changes Nov 14, 2023
View reviewed changes
Copy link
Collaborator

@Zeitsperre Zeitsperre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Approved for additional tests label Nov 14, 2023
@coveralls
Copy link

Coverage Status

coverage: 90.445%. first build
when pulling b1c0e42 on fix-1525
into d382912 on master.

@huard huard merged commit 209ee32 into master Nov 29, 2023
16 checks passed
@huard huard deleted the fix-1525 branch November 29, 2023 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zeitsperre Zeitsperre Zeitsperre approved these changes

Assignees
No one assigned
Labels
approved Approved for additional tests docs Improvements to documenation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Documentation: Indicator Search - Add YAML id to search functionality
3 participants
@huard @coveralls @Zeitsperre