Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't rate2amount with smaller-than-daily frequencies #1962

Closed
aulemahal opened this issue Oct 17, 2024 · 0 comments · Fixed by #1963
Closed

Can't rate2amount with smaller-than-daily frequencies #1962

aulemahal opened this issue Oct 17, 2024 · 0 comments · Fixed by #1963
Labels
bug Something isn't working
Milestone
v0.53.0

Comments

@aulemahal
Copy link
Collaborator

The line below has not been update since we switched to pandas' new frequency strings. In v0.49.0, we removed many entries from the FREQ_UNITS dict because the pandas strings are already understandable by pint. So at the minimum we should do FREQ_UNITS.get(base, base).

xclim/xclim/core/units.py

Line 670 in 2bb20af

m, u = multi, FREQ_UNITS[base]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
v0.53.0
Development

Successfully merging a pull request may close this issue.

Fix subdaily rate2amount, add hydro transformation from lwe thickness to amount Ouranosinc/xclim
1 participant
@aulemahal