Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the Secrets utility to be extendable #6

Open
joan38 opened this issue Sep 6, 2018 · 0 comments
Open

Refactor the Secrets utility to be extendable #6

joan38 opened this issue Sep 6, 2018 · 0 comments

Comments

@joan38
Copy link
Member

joan38 commented Sep 6, 2018

Motivation

The current Secret management utility object suffers from multiple flaws:

  1. It's not thread safe since https://github.com/Orkestra-Tech/orkestra/blob/master/orkestra-core/src/main/scala/tech/orkestra/utils/Secrets.scala#L4 is mutable without any atomicity.
  2. Is working with env var only and we might want to use something like HashiCorp Vault instead of the Kubernetes Env var Secrets.

Proposed change

Implementing a trait LogObfuscator as replacement of the Secrets object that would be responsible to obfuscate log and would be expected as input to the creation of a Job.
We would provide a default thread safe implementation for Kubernetes Env var Secrets and people would be free to implement one for any other sensible data provider that should not be logged.

This was one found on the spot, please tell me if you have a better idea.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant