Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Seal ModularTenantEvents & DeploymentSourceBase implementations #16897

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

Seal ModularTenantEvents & DeploymentSourceBase implementations #16897

wants to merge 17 commits into from

Conversation

hishamco
Copy link
Member

Fixes #16892

@hishamco
Copy link
Member Author

Don't seal Signal even it's inherited from ModularTenantEvents

@MikeAlhayek MikeAlhayek added this to the 3.0 milestone Oct 17, 2024
@MikeAlhayek
Copy link
Member

This has to wait until 3.0. I am adding do not merge label to ensure no one merges it in 2.x

This was referenced Nov 1, 2024
Open
Open
@MikeAlhayek
Copy link
Member

@hishamco please seal everything that is listed in the related issue #16892

Also, please document this in the 3.0.0 release notes.

MikeAlhayek
MikeAlhayek approved these changes Nov 24, 2024
View reviewed changes
src/docs/releases/3.0.0.md Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

This pull request has merge conflicts. Please resolve those before requesting a review.

hishamco
hishamco commented Nov 25, 2024
View reviewed changes
src/docs/releases/3.0.0.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikeAlhayek MikeAlhayek MikeAlhayek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.

Seal Handlers
2 participants
@hishamco @MikeAlhayek