Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lucene Query search result limited 10 records #16779

Open
gaojianzhuang opened this issue Sep 22, 2024 · 7 comments
Open

Lucene Query search result limited 10 records #16779

gaojianzhuang opened this issue Sep 22, 2024 · 7 comments

Comments

@gaojianzhuang
Copy link

gaojianzhuang commented Sep 22, 2024

Describe the bug

In the Lucene Query, if I run the match all and the result only displays 10 records the actual results count is 21.

image

Orchard Core version

1.8.4
image

Add the version of the Orchard Core NuGet packages you use, or the commit hash if you can reproduce this with the source code.

To Reproduce

Steps to reproduce the behavior:

  1. Go to 'Admin/Search/Lucene Indices'
  2. Click on 'Query' and click the "Match All query"
  3. Go to the search result and ensure the contents exceed 10 records.
  4. See error

Expected behavior

A clear and concise description of what you expected to happen.

Logs and screenshots

If applicable, add log files, browser console logs, and screenshots (or screen recording videos) to help explain your problem.

@gaojianzhuang gaojianzhuang changed the title Search result limited 10 records Lucene Query search result limited 10 records Sep 22, 2024
Copy link
Contributor

Thank you for submitting your first issue, awesome! 🚀 We're thrilled to receive your input. If you haven't completed the template yet, please take a moment to do so. This ensures that we fully understand your feature request or bug report. On what happens next, see the docs.

If you like Orchard Core, please star our repo and join our community channels.

@Piedone
Copy link
Member

Piedone commented Sep 22, 2024

10 is the default. You need to specify the size (and potentially from and sort) parameter in the query for a larger result set. E.g.:

{
  "query": {
    "match_all": { }
  },
  "size": 20
}

So, this is not a bug. Do you find anything can be improved to make this better discoverable?

Copy link
Contributor

github-actions bot commented Oct 7, 2024

It seems that this issue didn't really move for quite a while despite us asking the author for further feedback. Is this something you'd like to revisit any time soon or should we close? Please reply.

@github-actions github-actions bot added the stale label Oct 7, 2024
@gaojianzhuang
Copy link
Author

, this is not a bug. Do you find anythin

Thanks so much. If that is, could you please update the default query body with the default size of 10 when the user click the "Match All query" link? I think that more makes sense. Thanks. :)

@Piedone
Copy link
Member

Piedone commented Oct 9, 2024

Sure. So the task here is to update the default "Match All query" to the below one, making it apparent that there's a limit:

{
  "query": {
    "match_all": { }
  },
  "size": 10
}

@Piedone
Copy link
Member

Piedone commented Oct 10, 2024

This isn't completed.

@Piedone Piedone reopened this Oct 10, 2024
@sebastienros sebastienros added this to the 2.x milestone Oct 10, 2024
Copy link
Contributor

We triaged this issue and set the milestone according to the priority we think is appropriate (see the docs on how we triage and prioritize issues).

This indicates when the core team may start working on it. However, if you'd like to contribute, we'd warmly welcome you to do that anytime. See our guide on contributions here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants