Clean up remaining Bootstrap 3 code #501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Migrates off bootstrap3 and into bootstrap5. Thank you @psjalltheway !!! Removes deprecated files which are causing conflicts for the new HTML/CSS which will come in a separate PR. - [x] This branch is up-to-date with the `develop` branch. - [x] `pytest` passes on my local development environment. - [x] `pre-commit` passes on my local development environment. --------- Co-authored-by: psjalltheway <[email protected]> Co-authored-by: sea-kelp <[email protected]>
sea-kelp
commented
Sep 9, 2024
Comment on lines
+32
to
+43
| def strtobool(val: str) -> bool: | ||
| # Implemented based on distutils strtobool documentation | ||
| # https://docs.python.org/3.8/distutils/apiref.html#distutils.util.strtobool | ||
| val = str(val).lower() | ||
|
|
||
| if val in ["y", "yes", "t", "true", "on", "1"]: | ||
| return True | ||
|
|
||
| if val in ["n", "no", "f", "false", "off", "0"]: | ||
| return False | ||
|
|
||
| raise ValueError(f"string cannot be converted to boolean: {val}") |
There was a problem hiding this comment.
Added our own strtobool function since I was getting a build error which I think was caused by distutils being deprecated
AetherUnbound
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Cherry-picked from lucyparsons#1123
Migrates off bootstrap3 and into bootstrap5. Thank you @psjalltheway !!!
Removes deprecated files which are causing conflicts for the new HTML/CSS which will come in a separate PR.
Notes for Deployment
None, although we might need to clean up the unused nginx asset files?
Screenshots (if appropriate)
N/A
Testing instructions
I ran
just fresh-startlocally and made sure styles were still rendered correctlyChecks
I have rebased my changes on
mainjust lintpassesjust testpasses