Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated --fail-at-end option #3449

Merged
merged 1 commit into from
Nov 30, 2024

Conversation

bp7968h
Copy link
Contributor

@bp7968h bp7968h commented Nov 26, 2024

This PR removes the --fail-at-end cli args for hurl

Closes #3430

@jcamiel
Copy link
Collaborator

jcamiel commented Nov 26, 2024

You can search for all occurrence of fail-at-end in the project and remove them. There is at least this file docs/spec/options/hurl/fail_at_end.option that should be removed in this PR

@bp7968h
Copy link
Contributor Author

bp7968h commented Nov 27, 2024

Ohh, sorry I did not think about the docs. will do so thank you.

@jcamiel
Copy link
Collaborator

jcamiel commented Nov 27, 2024

@bp7968h you should also try to build the project when you make some changes:

$ cargo build
$ cargo fmt
$ cargo clippy

I think the project is not building, you can see some CI/CD here => https://github.com/Orange-OpenSource/hurl/actions/runs/12039416760/job/33571179719?pr=3449

@bp7968h
Copy link
Contributor Author

bp7968h commented Nov 29, 2024

Hi @jcamiel, can you please approve the workflow on this one too, thank you.

@jcamiel
Copy link
Collaborator

jcamiel commented Nov 29, 2024

Yes, can you squash the 2 commits for this PR? Thanks

@bp7968h
Copy link
Contributor Author

bp7968h commented Nov 29, 2024

Already done, thank you.

@jcamiel
Copy link
Collaborator

jcamiel commented Nov 29, 2024

You can delete all files in integration/hurl/tests_failed/fail_at_end* as this integration test is not needed anymore

@jcamiel
Copy link
Collaborator

jcamiel commented Nov 30, 2024

/accept

@hurl-bot
Copy link
Collaborator

🕗 /accept is running, please wait for completion.

@hurl-bot
Copy link
Collaborator

✅ Pull request merged and closed by jcamiel with fast forward merge..

# List of commits merged from bp7968h/hurl/enhance-3430 branch into Orange-OpenSource/hurl/master branch:

  • 836ecf6 enhance/hurl: remove depreciated --fail-at-end option

@hurl-bot hurl-bot closed this Nov 30, 2024
@hurl-bot hurl-bot merged commit 836ecf6 into Orange-OpenSource:master Nov 30, 2024
23 checks passed
@bp7968h bp7968h deleted the enhance-3430 branch December 1, 2024 00:18
@jcamiel jcamiel changed the title enhance/hurl: remove depreciated --fail-at-end option Hurl: remove depreciated --fail-at-end option Dec 2, 2024
@jcamiel jcamiel changed the title Hurl: remove depreciated --fail-at-end option Remove depreciated --fail-at-end option Dec 2, 2024
@jcamiel jcamiel changed the title Remove depreciated --fail-at-end option Remove deprecated --fail-at-end option Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove --fail-at-end deprecated option
3 participants