Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12.0] ow_notify: Chrome (Android) gives error on push notificationFailed to construct 'Notification': Illegal constructor. Use ServiceWorkerRegistration.showNotification() instead. #9

Open
mgielissen opened this issue Mar 24, 2019 · 2 comments

Comments

@mgielissen
Copy link
Contributor

I improved with 5075c8a the push notification for supported browsers.

Push notification works on Firefox & Chrome Desktop browsers and also on Firefox Mobile (Android), but on Chrome Android it shows the error: "Failed to construct 'Notification': Illegal constructor. Use ServiceWorkerRegistration.showNotification() instead."

@mgielissen mgielissen changed the title [12.0] ow_notify: Failed to construct 'Notification': Illegal constructor. Use ServiceWorkerRegistration.showNotification() instead. [12.0] ow_notify: Chrome (Android) gives error on push notificationFailed to construct 'Notification': Illegal constructor. Use ServiceWorkerRegistration.showNotification() instead. Mar 24, 2019
@keshrath
Copy link

Wouldn't it be better instead of replacing MessagingMenu to include the extended functionality in the existing one? Otherwise this addon will destroy all MessagingMenu extensions. It would also make it easier to determine what new code is and what is a copy and paste of the existing MessagingMenu.

@mgielissen
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants