Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat]: Improve Validation in Testimonial form #561

Open
4 tasks done
AlfiyaSiddique opened this issue Jul 26, 2023 · 1 comment
Open
4 tasks done

[Feat]: Improve Validation in Testimonial form #561

AlfiyaSiddique opened this issue Jul 26, 2023 · 1 comment

Comments

@AlfiyaSiddique
Copy link
Contributor

AlfiyaSiddique commented Jul 26, 2023

Is your feature request related to a problem? Please describe.

No but I have some improvement points that can be added to the testimonial form for receiving valid data. These are as follows:

  1. Add max character length limit in the name field. (Max 20)
  2. Use a Dropdown for Position input and add all possible related roles like admin, maintainer, contributor, user, member, etc as the options. This will help to prevent adding irrelevant data. Also we if change the label position to Role then it will be more understandable, let me know your opinion on this.
  3. Limit the number of words for the Quote field. max(60 words)

I will also implement inline validation in required fields

If you approve this issue let me know if you want me to change any of the above constraints

Describe the solution you'd like.

No response

Describe alternatives you've considered.

No response

Additional context.

No response

Show us the magic with screenshots

No response

Checklist

@github-actions
Copy link

Hello👋 @AlfiyaSiddique, I hope you are doing well!
Thank you for raising an issue. We will will investigate into the issue and get back to you as soon as possible. Please make sure you have given us as much context as possible.
Feel free to join the community and collaborate ❤
Join our Discord Community here and make sure to STAR the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant