Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@openzeppelin/hardhat-upgrades does not install with latest hardhat-toolbox #932

Closed
Therecanbeonlyone1969 opened this issue Dec 1, 2023 · 5 comments

Comments

@Therecanbeonlyone1969
Copy link

Therecanbeonlyone1969 commented Dec 1, 2023

After the latest hardhat upgrade, the hardhat-toolbox library has a dependency conflict due to different versions of the verify package in the hardhat-upgrades and the hardhat-tool box libraries when trying to install hardhat-upgrades.

hardhat-upgrades library needs to be upgraded to the latest version of the verify package.

see PR #912 from renovate bot

@ericglau
Copy link
Member

ericglau commented Dec 1, 2023

Thanks for raising this. We will likely make this change in hardhat-upgrades v3 which will be a major version bump (current alpha version available here does not include this yet).

@Therecanbeonlyone1969
Copy link
Author

Thanks for raising this. We will likely make this change in hardhat-upgrades v3 which will be a major version bump (current alpha version available here does not include this yet).

Thank you for sharing this!

Timeline? I have a tight timeline. As a workaround, should I uninstall the hardhat-toolbox and then install upgrades?

@ericglau
Copy link
Member

ericglau commented Dec 1, 2023

As a workaround, you could force install hardhat-upgrades along with hardhat-verify v2. hardhat-upgrades should still work with hardhat-verify v2 for Etherscan verification, but it won't support Sourcify verification.

@cryptobanksy
Copy link

cryptobanksy commented Dec 5, 2023

npm i -D @openzeppelin/hardhat-upgrades @nomicfoundation/hardhat-verify@^2.0 --force

and require hardhat-upgrades in hardhat.config.js

require("@nomicfoundation/hardhat-toolbox");
require('@openzeppelin/hardhat-upgrades');

@ericglau
Copy link
Member

We've released @openzeppelin/[email protected] which resolves this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants