-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for secp256r1 #987
Milestone
Comments
4 tasks
ericnordelo
changed the title
Add trait (Serde, Debug, Eq), store and is_valid_xxx_signature and tests for secp256r1
Add support for secp256r1
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
🧐 Motivation
OpenZeppelin/cairo-contracts
includes a number of utils to support secp256k1:These tools are used internally in
OpenZeppelin/cairo-contracts
to implement the Eth Account. They are also available for third party projects that uses your project as a library. We use them in our starknet-modular-account project.We have implemented the same set of tools for secp256r1 that is also supported by the starknet corelib. We would like to submit a PR that them so that we can rely on them the same way we rely on your secp256k1 implementation.
📝 Details
See PR #988 for details about the implementation. We've done the adaptation from secp256k1 to secp256r1 but, except for the mapping between the functions and features the implementation is the same.
The text was updated successfully, but these errors were encountered: