Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lost bits in value index (severe bug for some use cases) -- with FIX #212

Open
brandyn opened this issue Jun 19, 2023 · 0 comments
Open

Lost bits in value index (severe bug for some use cases) -- with FIX #212

brandyn opened this issue Jun 19, 2023 · 0 comments

Comments

@brandyn
Copy link

brandyn commented Jun 19, 2023

https://github.com/OpenZWave/python-openzwave/blob/8be4c070294348f3fc268bc1d7ad2c535f352f5a/src-lib/libopenzwave/values.pxd#LL51C1-L51C27

The GetIndex declaration should read uint16_t, not uint8_t (also need to add uint16_t to cimport line at top).

As-is, bits are dropped from the index, causing apparently-redundant values in any system that (reasonably) identifies values by cc/inst/index tuples.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@brandyn