Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No install(runepanet) in CMakeLists.txt #796

Open
0tkl opened this issue May 29, 2024 · 0 comments
Open

No install(runepanet) in CMakeLists.txt #796

0tkl opened this issue May 29, 2024 · 0 comments

Comments

@0tkl
Copy link
Contributor

0tkl commented May 29, 2024

I suggest adding something like

 target_include_directories(epanet2 PUBLIC ${PROJECT_SOURCE_DIR}/include)
 
+IF (NOT BUILD_PY_LIB)
+  install(TARGETS runepanet DESTINATION bin)
+ENDIF (NOT BUILD_PY_LIB)
 install(TARGETS epanet2 DESTINATION lib)
 install(FILES ./include/epanet2.h DESTINATION include)
 install(FILES ./include/epanet2_2.h DESTINATION include)

to CMakeList.txt. It would be helpful for packagers. Yeah, I have put it on Archlinux User Repo and I'd like to submit v2.3 to Debian in the future.

Btw, the BUILD_PY_LIB option looks counter-intuitive, from a packager's perspective. The library seems to be built under any input option, although it could be either static-linked or shared (controled by BUILD_SHARED_LIBS). If it doesn't break compatibility, I think flip BUILD_PY_LIB and use a more straightforward name BUILD_EXECUTABLE/BUILD_BIN would be better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant