Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Class/module name overwritten? #214

Closed
ChanceNCounter opened this issue Jan 1, 2024 · 0 comments · May be fixed by #225
Closed

Class/module name overwritten? #214

ChanceNCounter opened this issue Jan 1, 2024 · 0 comments · May be fixed by #225
Labels
bug Something isn't working question Further information is requested

Comments

@ChanceNCounter
Copy link
Contributor

ovos-utils/ovos_utils/log.py

Lines 82 to 88 in 6936b3a

name = os.getenv("OVOS_DEFAULT_LOG_NAME") or 'OVOS'
level = os.getenv("OVOS_DEFAULT_LOG_LEVEL") or "INFO"
diagnostic_mode = False
_loggers = {}
@classmethod
def __init__(cls, name='OVOS'):

That looked hinky to me while investigating an unrelated dev question. Is this overwriting the name before initializing the logger?
@ChanceNCounter ChanceNCounter added bug Something isn't working question Further information is requested labels Jan 1, 2024
@JarbasAl JarbasAl removed their assignment Jan 2, 2024
@mikejgray mikejgray mentioned this issue Jan 31, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working question Further information is requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: clean up types, address name overwrite mikejgray/ovos-utils
2 participants
@ChanceNCounter @JarbasAl