Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not release GUI when completed #3

Open
builderjer opened this issue Jun 2, 2021 · 2 comments
Open

Does not release GUI when completed #3

builderjer opened this issue Jun 2, 2021 · 2 comments

Comments

@builderjer
Copy link
Member

Great skill, and for the most part works well. First issue, when it is done with the "how to", it should release the GUI and return to the home screen, but does not seem to do so. When I call another skill, that skill shows up, but when completed, the last page of the how to is still present.

The other thing I would like to see is being able to stop it before it ends. It seems that I have to let the whole how to play

@JarbasAl
Copy link
Member

how do i know about when it is done to release it? the user can go back and forth between steps

i will need to give this some further thought, it sounds like idle screen manager responsibility to clean this sort of stuff up, eg, user abandoning interaction / timeout

i did account for stop, so i need to look into it, sounds like a bug!

@builderjer
Copy link
Member Author

It will pause and continue. And I can even go back pages. But when it is done with the how to, it stays at the last pict. Not sure if that has to do with the home screen or not. Others release back, eg. The weather and time skill. Any logs, let me know. I'd love for this to work correctly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants