Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/drop_ww_sounds_from_STT_audio #126

Closed
JarbasAl opened this issue Jun 19, 2024 · 0 comments
Closed

feat/drop_ww_sounds_from_STT_audio #126

JarbasAl opened this issue Jun 19, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@JarbasAl
Copy link
Member

          if we want to know when sound stops playing
    def _play_sound(self, uri: str, timeout=0.5, message: Optional[Message] = None):
        message = message or Message("", context={
            'client_name': 'ovos_dinkum_listener', 'source': 'listener',
            'destination': ["audio"]  # default native-source
        })
        self.bus.emit(message.forward("mycroft.audio.play_sound", {"uri": uri}))
        # block waiting for ovos-audio to report sound finished playing
        if not self.config.get("instant_listen", True):
            sess = SessionManager.get(message)
            SessionManager.wait_while_speaking(timeout=timeout, session=sess)

we could use this to to know how much time (and therefore chunks) to drop from beginning of STT audio

but i would put this into it's own flag and do it in a separated PR

Originally posted by @JarbasAl in #125 (comment)

@JarbasAl JarbasAl added the enhancement New feature or request label Jun 19, 2024
@github-actions github-actions bot mentioned this issue Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant