Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider expanding the configuration for more comprehensive localization. #159

Open
JarbasAl opened this issue Sep 25, 2024 · 0 comments
Open

Comments

@JarbasAl
Copy link
Member

          _:hammer_and_wrench: Refactor suggestion_

Consider expanding the configuration for more comprehensive localization.

The current configuration covers basic localization settings, which is a good start. To make it more comprehensive, consider adding the following:

  1. Currency symbol and format
  2. Number format (decimal separator, thousands separator)
  3. First day of the week
  4. Paper size (A4 is standard in the UK)
  5. Temperature unit (Celsius is standard in the UK)

Here's an example of how you might expand the configuration:

{
  // Existing settings...

  // Currency symbol and format
  "currency_symbol": "£",
  "currency_format": "symbol_first",

  // Number format
  "decimal_separator": ".",
  "thousands_separator": ",",

  // First day of the week (0 for Sunday, 1 for Monday)
  "first_day_of_week": 1,

  // Paper size
  "paper_size": "A4",

  // Temperature unit
  "temperature_unit": "celsius"
}

These additional settings would provide a more complete localization profile for British English users.

Originally posted by @coderabbitai[bot] in #158 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant