orjson: we should test if we can remove the `.decode()` call here. It's in place to force the return value to be a string instead of bytes, for consistency, but bytes might be fine. Would require extensive testing in a whole system to be sure. #113

JarbasAl · 2024-09-10T16:35:20Z

          Note for the future: we should test if we can remove the `.decode()` call here. It's in place to force the return value to be a string instead of bytes, for consistency, but bytes might be fine. Would require extensive testing in a whole system to be sure.

Originally posted by @mikejgray in #107 (comment)

The text was updated successfully, but these errors were encountered:

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

orjson: we should test if we can remove the `.decode()` call here. It's in place to force the return value to be a string instead of bytes, for consistency, but bytes might be fine. Would require extensive testing in a whole system to be sure. #113

orjson: we should test if we can remove the `.decode()` call here. It's in place to force the return value to be a string instead of bytes, for consistency, but bytes might be fine. Would require extensive testing in a whole system to be sure. #113

JarbasAl commented Sep 10, 2024

orjson: we should test if we can remove the .decode() call here. It's in place to force the return value to be a string instead of bytes, for consistency, but bytes might be fine. Would require extensive testing in a whole system to be sure. #113

orjson: we should test if we can remove the .decode() call here. It's in place to force the return value to be a string instead of bytes, for consistency, but bytes might be fine. Would require extensive testing in a whole system to be sure. #113

Comments

JarbasAl commented Sep 10, 2024

orjson: we should test if we can remove the `.decode()` call here. It's in place to force the return value to be a string instead of bytes, for consistency, but bytes might be fine. Would require extensive testing in a whole system to be sure. #113

orjson: we should test if we can remove the `.decode()` call here. It's in place to force the return value to be a string instead of bytes, for consistency, but bytes might be fine. Would require extensive testing in a whole system to be sure. #113