Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TCP_NODELAY is not supported #90

Open
ValdikSS opened this issue Oct 30, 2024 · 1 comment
Open

TCP_NODELAY is not supported #90

ValdikSS opened this issue Oct 30, 2024 · 1 comment

Comments

@ValdikSS
Copy link

As of 1.2.1, TCP_NODELAY socket option (--tcp-nodelay or --socket-flags TCP_NODELAY) doesn't do anything, silently.
OpenVPN skips is in case of DCO-win, and there's no API to set it in the kernel driver.

https://github.com/OpenVPN/openvpn/blob/a7f80d402fb95df3c58a8fc5d12cdb8f39c37d3e/src/openvpn/socket.c#L957-L961

static bool
socket_set_flags(socket_descriptor_t sd, unsigned int sockflags)
{
    /* SF_TCP_NODELAY doesn't make sense for dco-win */
    if ((sockflags & SF_TCP_NODELAY) && (!(sockflags & SF_DCO_WIN)))
@lstipakov
Copy link
Member

@cron2 Shall we just enable it by default?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants