/Plugins: Refactor (noscript, less pop-in, etc)
#132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gonX
added
bug
gonX
changed the title
/Plugins: Add noscript support, and reduce jarringness of plugins' JS sort/Plugins: Refactor (noscript, less pop-in, etc)
|
Marking as draft because I have some better ideas to fix this, but it would require porting the current Javascript filtering logic over to our Liquid templates instead |
|
Worth moving over Bootstrap's placeholders instead. At a quick glance, it seems like they can also be used in a way that is noscript friendly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This hides the search boxes for noscript users as they only have a function with JavaScript. Additionally, we inform the user when JavaScript is disabled.
Technically fixes #91 but I'm not sure if this is the desired fix (flashing the list in from nothing instead of cards disappearing after sort)
Here's what it looks like with Javascript disabled on this page:
