Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use original filenames #139

Open
X9VoiD opened this issue Dec 22, 2023 · 2 comments
Open

Use original filenames #139

X9VoiD opened this issue Dec 22, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request wiki Improvements or additions to the wiki

Comments

@X9VoiD
Copy link
Member

X9VoiD commented Dec 22, 2023

These are the original filenames for release assets.

image

In the future we might offer official arm64 releases so renaming the release assets to generic names is not going to be something we're doing when it happens.

This image for example should say and download opentabletdriver-0.6.4.0-1.x86_64.rpm

image

Related upstream issue: OpenTabletDriver/OpenTabletDriver#3123

@gonX gonX added enhancement New feature or request wiki Improvements or additions to the wiki labels Jan 2, 2024
@gonX
Copy link
Member

gonX commented Jan 2, 2024

How would you prefer this to be fixed? Can we grab the release names from the git repo itself (ie. submodule), or does this need a GitHub API call on build? Or would you like to just check for both old and new names on compile time?

@X9VoiD
Copy link
Member Author

X9VoiD commented Jan 28, 2024

Can we pull jsons and read from that when building the site? We can probably put a json in master that defines the filenames for the downloads. Something like:

https://raw.githubusercontent.com/OpenTabletDriver/OpenTabletDriver/master/metadata.json

{
    "versions": [
        "0.5.0.0",
        "0.5.0.1",
        ...
    ],
    "latestReleaseFilenames": {
        "windows": "https://github.com/OpenTabletDriver/OpenTabletDriver/releases/download/<version>/opentabletdriver.windows-<version>.<arch>.zip",
        "deb": "https://github.com/OpenTabletDriver/OpenTabletDriver/releases/download/<version>/opentabletdriver-<version>.<arch>.deb",
        ...
    }
}

This theoretically solves both needing to update versions manually from this side and this issue.

@gonX gonX self-assigned this Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request wiki Improvements or additions to the wiki
Projects
None yet
Development

No branches or pull requests

2 participants