Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(translations): fix text translations after language change #181

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

mellodev
Copy link
Contributor

@mellodev mellodev commented Dec 5, 2024

Changes Proposed

Refactor view logic

  • Logs: refactor the view logic from ui-dom to OSApp.Logs.displayPage()
  • Programs: refactor view logic from ui-dom to OSApp.Programs.displayPage()
  • Manual Control: refactor view logic from ui-dom to OSApp.Programs.displayPageManual()
  • About: refactor view logic from ui-dom to OSApp.About.displayPage(); update related files for imports
  • Run Once: refactor view logic from ui-dom to OSApp.Programs.displayPageRunOnce()
  • Preview Programs: refactor view logic from ui-dom to OSApp.Programs.displayPagePreviewPrograms()
  • Welcome Screen: refactor view logic from ui-dom to OSApp.Welcome.displayPage(); update related files for imports
  • Manage Sites: refactor view logic from ui-dom to OSApp.Sites.displayPage()
  • Home Dashboard: refactor view logic from ui-dom to OSApp.Dashboard.displayPage(); update related files for imports

UI Elements manually re-rendered on language change:

  • Dashboard - Current Weather widget
  • Dashboard - Water Level

Demo Video or Screenshots

Watch: https://streamable.com/kdhq7r

@mellodev mellodev marked this pull request as ready for review December 6, 2024 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Text translations are called before language is initialized
1 participant