lint: Fix rubocop offenses

OpenSourcePolitics · Dec 22, 2023 · db9cccb · db9cccb
1 parent 6a6db38
commit db9cccb
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 6 deletions.
diff --git a/.../20231221231804_create_decidim_proposals_proposal_state.decidim_custom_proposal_states.rb b/.../20231221231804_create_decidim_proposals_proposal_state.decidim_custom_proposal_states.rb
@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 # This migration comes from decidim_custom_proposal_states (originally 20231102173159)
 
 class CreateDecidimProposalsProposalState < ActiveRecord::Migration[6.0]
@@ -19,4 +20,4 @@ def change
       t.string :css_class
     end
   end
-end
+end
diff --git a/...31221231805_add_state_id_to_decidim_proposals_proposals.decidim_custom_proposal_states.rb b/...31221231805_add_state_id_to_decidim_proposals_proposals.decidim_custom_proposal_states.rb
@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 # This migration comes from decidim_custom_proposal_states (originally 20231102173214)
 
 class AddStateIdToDecidimProposalsProposals < ActiveRecord::Migration[6.0]
@@ -12,4 +13,4 @@ def down
     remove_foreign_key :decidim_proposals_proposals, column: :decidim_proposals_proposal_state_id
     remove_column :decidim_proposals_proposals, :decidim_proposals_proposal_state_id
   end
-end
+end
diff --git a/db/migrate/20231221231806_create_default_proposal_states.decidim_custom_proposal_states.rb b/db/migrate/20231221231806_create_default_proposal_states.decidim_custom_proposal_states.rb
@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 # This migration comes from decidim_custom_proposal_states (originally 20231102234909)
 
 class CreateDefaultProposalStates < ActiveRecord::Migration[6.0]
@@ -15,17 +16,19 @@ class Proposal < ApplicationRecord
   def up
     return unless Decidim.version.to_s.include?("0.26")
 
+    # rubocop:disable Lint/UselessAssignment
     states = {
-      "0"  => :not_answered,
+      "0" => :not_answered,
       "10" => :evaluating,
       "20" => :accepted,
       "-10" => :rejected,
       "-20" => :withdrawn
     }
-
+    # rubocop:enable Lint/UselessAssignment
+    # rubocop:disable Rails/SkipsModelValidations
     Proposal.where(state: "").update_all(state: "not_answered")
     Proposal.where(state: nil).update_all(state: "not_answered")
-
+    # rubocop:enable Rails/SkipsModelValidations
     Decidim::Component.where(manifest_name: "proposals").find_each do |component|
       admin_user = component.organization.admins.first
       default_states = Decidim::CustomProposalStates.create_default_states!(component, admin_user).with_indifferent_access
@@ -38,4 +41,4 @@ def up
   end
 
   def down; end
-end
+end