Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

when camera disabled image at position 0 acts as camera button #13

Open
LoaayElkherbawy opened this issue Aug 7, 2020 · 1 comment
Open
Assignees
Labels
bug Something isn't working

Comments

@LoaayElkherbawy
Copy link

Describe the bug
Thanks for the awesome library, However when setting camera disabled to true it only hides the capture new image button however on clicking the image at position 0 the camera is opened

To Reproduce
Steps to reproduce the behavior:

  1. Set camera disabled to true
  2. Click on the first image
  3. Camera will open instead of marking the image as selected

Expected behavior
When camera is disabled images at position 0 should be marked as selected instead of opening the camera

Additional context
The override fun onItemClicked(position: Int) {
when (position) {
0 -> openCamera()
else -> {
mainViewModel.setImageSelection(position, mImagesAdapter?.images)
}
}
} inside ImagePickerActivity ImagePickerActivity should check on the disabledCamera attribute as well not only the position I would have loved to create a branch with the fix in order to support more but am still trying to get the hang of kotlin

@ASHIR14
Copy link

ASHIR14 commented Aug 19, 2020

I have the same issue

@hani-momanii hani-momanii added the bug Something isn't working label Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants