Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend Importing Function with the Import Matching #5

Closed
jeremi opened this issue Jun 22, 2023 · 8 comments · Fixed by #8
Closed

Extend Importing Function with the Import Matching #5

jeremi opened this issue Jun 22, 2023 · 8 comments · Fixed by #8
Assignees

Comments

@jeremi
Copy link
Member

jeremi commented Jun 22, 2023

https://github.com/OpenSPP/openspp-registry/pull/237#pullrequestreview-1492306958

move the code to openspp_base

How to Use:

  1. Create an Import Matching
  • Go to Registry > Configuration > Import Match
  • Click Create Button
  • Select the Model for the Import Match
  • Add the Fields to be used in Import Matching
  • Check Overwrite Match if you want Matched Data to be overwritten or don't check if you want to Ignore those matched data.
  • Click Save.
@gonzalesedwin1123
Copy link
Member

@emjay0921, please provide updates for this ticket.

@emjay0921 emjay0921 linked a pull request Jul 5, 2023 that will close this issue
@emjay0921
Copy link
Collaborator

emjay0921 commented Jul 5, 2023

I moved the spp_import_match from openspp-registry to openspp-base

@gonzalesedwin1123
Copy link
Member

@emjay0921 as discussed in our meeting, please add a way for the user to not perform an update if the key field already exist. You can display an error to present to the user that the key field already exist.

@emjay0921
Copy link
Collaborator

Done @gonzalesedwin1123

@emjay0921 emjay0921 changed the title Implement import matcher Extend Importing Function with the Import Matching Jul 21, 2023
@emjay0921
Copy link
Collaborator

emjay0921 commented Jul 21, 2023

July 21, 2023 Requested Changes:

  • Add a dropdown list on the Importing UI to choose which Import Matching Configuration to use before Importing.
  • Remove SQL Constraints in the Import Matching Configuration for Models to be able to create multiple configuration for a model.

Estimated duration for this Changes: 16Hrs

To be move to new ticket instead and for next iteration.

@adriancris
Copy link

Setting the status back to In progress as @emjay0921 is working on the request changes now

@emjay0921
Copy link
Collaborator

Setting the status back to Done. The advance feature of the Importing will be transferred to new ticket and iteration.

@adriancris
Copy link

tested for a while but was halted because as per dev assigned, "advance feature of the Importing will be transferred to new ticket and iteration"

advance feature of the Importing ticket - Improve the odoo import match module to support multiple import configuration #20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants