Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The Windows package build still references System.Drawing. #123

Open
GraionDilach opened this issue Sep 28, 2019 · 1 comment
Open

The Windows package build still references System.Drawing. #123

GraionDilach opened this issue Sep 28, 2019 · 1 comment
Labels
Bug

Comments

@GraionDilach
Copy link

OpenRAModSDK/packaging/windows/buildpackage.sh

Line 49 in 5e1de71

LAUNCHER_LIBS="-r:System.dll -r:System.Drawing.dll -r:System.Windows.Forms.dll -r:${BUILTDIR}/OpenRA.Game.exe"

Something I noticed during going after OpenRA/d2#140.
@evgeniysergeev evgeniysergeev mentioned this issue Sep 28, 2019
Open
@GraionDilach
Copy link
Author

Appatrently this is part for the Windows error crash dialog, but since that shares the namespace... is there a need for this one?

@Mailaender Mailaender added the Bug label Jan 1, 2020
@pchote pchote mentioned this issue Sep 2, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace WinForms crash dialog with SDL_ShowMessageBox. pchote/OpenRA
2 participants
@Mailaender @GraionDilach