Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manually Deleted VMs are not recreated #562

Closed
Thiryn opened this issue Jul 19, 2024 · 5 comments · Fixed by #563
Closed

Manually Deleted VMs are not recreated #562

Thiryn opened this issue Jul 19, 2024 · 5 comments · Fixed by #563
Labels
status: triage type: bug

Comments

@Thiryn
Copy link
Contributor

Thiryn commented Jul 19, 2024 •
edited
Loading

Description

Terraform does not detect any drift for VMs created using opennebula_virtual_machine and opennebula_virtual_router_instance that are terminated from the UI (therefor in DONE state).

I assume this is because the VM state is ignored from the terraform state lifecycle. I am also afraid that running the DB cleaning tool (actually deleting VMs in DONE state) will trigger the recreation of the VM (as the ID will be not found), leading to more inconsistency when managing VMs instances via terraform.

Terraform and Provider version

Terraform v1.7.3
on darwin_arm64

  • provider registry.terraform.io/opennebula/opennebula v1.4.0

Affected resources and data sources

opennebula_virtual_machine and opennebula_virtual_router_instance

Terraform configuration

resource "opennebula_virtual_router_instance" "v-router-instance" {
  name   = "virtual-router-instance"
  group  = "oneadmin"
  memory = 128
  cpu    = 0.1

  virtual_router_id = 1
}

Expected behavior

When terminating the VM from the UI, subsequent runs of terraform plan should pick up the VM is now in DONE state and recreate it.

Actual behavior

No drift are detected.

Steps to Reproduce

Create a VM with terraform, terminate it from the UI, run terraform plan.

Debug output

No response

Panic output

No response

Important factoids

No response

References

No response
@Thiryn Thiryn changed the title Manually Deleted VMs not recreated Manually Deleted VMs are not recreated Jul 19, 2024
@Thiryn Thiryn mentioned this issue Jul 22, 2024
Merged
7 tasks
@treywelsh
Copy link
Collaborator

"General" issue around state management: #492

@Thiryn
Copy link
Contributor Author

Thiryn commented Aug 8, 2024

I think the two issues tackle two different use cases:
#492 relates to the desired state, in a way that it can be changed (Running, Stopped, Hold)

This issue relate to the existence of the VM altogether. To compare to AWS as on the other ticket, an AWS EC2 instance that's deleted has the terminated state and eventually disappears from the AWS API. As the Instance would disappear from the API, the AWS TF provider would automatically recreate the instance (as not found upon read).

The difference here is in the way that deleted VMs are handled in OpenNebula. ON sets the final done state to a VM. Final in the sense that there is no further state that the VM can change to after done. See the ON state management diagram here.

While the detection of the vm existence is done by checking if the vm_state == done, the desired outcome of this issue is not to implement vm_state management.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 8, 2024

This issue is stale because it has been open for 30 days with no activity and it has not the 'status: confirmed' label or it is not in a milestone. Remove the 'status: stale' label or comment, or this will be closed in 5 days.

@fsdaniel
Copy link

fsdaniel commented Sep 9, 2024

Not stale

@github-actions GitHub Actions
Copy link

This issue is stale because it has been open for 30 days with no activity and it has not the 'status: confirmed' label or it is not in a milestone. Remove the 'status: stale' label or comment, or this will be closed in 5 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: triage type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow to recreate VMs if in DONE state Thiryn/terraform-provider-opennebula
3 participants
@fsdaniel @Thiryn @treywelsh