Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding NeuralNetwork v2.0.0 #23

Merged
merged 1 commit into from
Jul 12, 2024
Merged

Adding NeuralNetwork v2.0.0 #23

merged 1 commit into from
Jul 12, 2024

Conversation

AnHeuermann
Copy link
Member

Changes

@AnHeuermann
Copy link
Member Author

AnHeuermann commented Jul 8, 2024

I'm not sure how to add NeuralNetwork to repos.json.
There is already a key for NeuralNetwork with the v1.0.0 version. How to add v2.0.0 with the new repo while keeping version v1.0.0? Or should we simply remove the old v1.0.0 version based on MSL 2.2?

@AnHeuermann AnHeuermann marked this pull request as draft July 8, 2024 15:30
@AnHeuermann AnHeuermann requested a review from sjoelund July 8, 2024 15:30
@AnHeuermann AnHeuermann marked this pull request as ready for review July 12, 2024 07:56
@sjoelund
Copy link
Member

It should read tags automatically. Never update rawdata.json in a PR. Jenkins does that for you later on.

@AnHeuermann
Copy link
Member Author

Okay, then I'll rename the tag v1.0.0 to v1.0 to don't have any duplicates and undo the rawdata.json changes.

@sjoelund
Copy link
Member

You might also want to check with @dietmarw about making modelica-3rdparty track the new repo

@AnHeuermann AnHeuermann merged commit 70d29a6 into master Jul 12, 2024
1 check passed
@AnHeuermann AnHeuermann deleted the add-NeuralNetwork-v2 branch July 12, 2024 08:30
@dietmarw
Copy link
Contributor

You might also want to check with @dietmarw about making modelica-3rdparty track the new repo

I see quite a serious legal issue here. You say you merged the original https://github.com/modelica-3rdparty/NeuralNetwork into this project. But as the original repo states, it does not have a licence that would allow you to do so.

That leaves you with two options:

  1. Try to get permission from the original author (Fabio Codecà, Politecnico Di Milano)
  2. Rewrite this library from scratch without any code from the original author

Anything else is illegal and unethical I'm afraid.

@dietmarw
Copy link
Contributor

So I suggest you discuss this with your co-authors: @bernhardbachmann, @phannebohm, @SoeMoeller since they would be liable too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants