Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation suggestion: unique URLs #4100

Open
kengruven opened this issue Jul 19, 2024 · 3 comments
Open

Validation suggestion: unique URLs #4100

kengruven opened this issue Jul 19, 2024 · 3 comments
Labels
component-test Affects the automated tests.

Comments

@kengruven
Copy link
Contributor

There are a lot of proposed fixtures I see where someone adds a bunch of URLs, all the same. (The most common is probably productPage and manual being the same.) I don't think it's ever correct for different URLs to be identical, so it would be nice if we could catch that before the JSON is submitted.

@THEBOSS0369
Copy link

Then it would be nice to implement a validation step that would check if these URL's are different or not

@Zaraka
Copy link
Contributor

Zaraka commented Sep 4, 2024

The most common is probably productPage and manual being the same.
Cameo QSpot 40 CW and WW have the same manual even though they are different fixtures with different specs, the manual lists both of them, DMX table is the same for both of them.

@kengruven
Copy link
Contributor Author

The most common is probably productPage and manual being the same.
Cameo QSpot 40 CW and WW have the same manual even though they are different fixtures with different specs, the manual lists both of them, DMX table is the same for both of them.

That's not what this is about, if I'm reading you right. What I'm saying is that it's (almost certainly) an error when one fixture has the same URL for its productPage and manual.

I'm not proposing to add a global uniqueness constraint for all manual links -- there's no need for that, and there'd be no way to enforce it, anyway.

@FloEdelmann FloEdelmann added the component-test Affects the automated tests. label Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component-test Affects the automated tests.
Projects
None yet
Development

No branches or pull requests

4 participants