Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-module push doesn't work when top-level reactor build is a peer of the individual module directories #161

Open
scottkurz opened this issue Sep 22, 2021 · 0 comments
Labels
bug Something isn't working Type: Documentation Improvements or additions to documentation

Comments

@scottkurz
Copy link
Member

For a project structure like: https://github.com/IBMTechSales/openshift-workshop-was/tree/master/labs/Openshift/RuntimeModernization/app

the subdirectories are:

CustomerOrderServices
CustomerOrderServicesApp
CustomerOrderServicesProject
CustomerOrderServicesTest
CustomerOrderServicesWeb

with CustomerOrderServicesProject the "top-level" POM from the reactor build perspective.

If we do odo push we're going to fail since there's no pom.xml in the parent directory '..../app' which contains all these modules.


Even if it's not feasible to write a single devfile that works for all possible module layouts.. we should at least give some guidance, possibly a better error msg even, for a structure like this.

And we might want to have a "root_module" devfile variable perhaps.

@scottkurz scottkurz added bug Something isn't working Type: Documentation Improvements or additions to documentation labels Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Type: Documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

1 participant