-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Room Vacancy And Lost & Found #18
Room Vacancy And Lost & Found #18
Conversation
There are two things that are not in this PR:
Both of these need credentials of the logged in user to be stored locally on device but were not included in #14 but will be included in #19 along with the token required logic on the frontend aswell. Also this PR has both http and Dio packages, http was used by one of our team member and we have decided to migrate to Dio and the migration will be completed in #19 aswell |
Requesting review @henilp105 @Akshatji800 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Nailsonseat, looks good to me, minor comments.
Thank you @henilp105 for the review
Also please ignore the failed workflow build, it is because the .env file is ignored by the gitignore but at the same time it is also mentioned in pubspec.yaml as an asset required by the dotenv package. I will make a PR soon to edit the build workflow to make a empty dummy .env by Requesting review @henilp105 |
Room Vacancy
Lost and Found