Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Room Vacancy And Lost & Found #18

Merged
merged 52 commits into from
Feb 10, 2024

Conversation

Nailsonseat
Copy link
Contributor

@Nailsonseat Nailsonseat commented Feb 6, 2024

Room Vacancy

  • Grid wise color coded tiles indicating vacancy.
  • Display the name of occupant.*

Lost and Found

  • Custom image tile for displaying the listed item
  • Item can be listed as Lost or Found
  • Features image cropper and forces the selected image in 4:3 for consistent image size in the tiles
  • Supports both camera and gallery for listing
  • A button to launch dialer app, for a listing's phone number
Screenshot from 2024-02-06 14-26-20 Screenshot from 2024-02-06 14-26-15
Screenshot from 2024-02-06 14-50-57 Screenshot from 2024-02-06 14-27-16
Screenshot from 2024-02-06 14-26-49
Screenshot from 2024-02-06 14-51-10

@Nailsonseat Nailsonseat marked this pull request as draft February 6, 2024 18:20
@Nailsonseat Nailsonseat marked this pull request as ready for review February 6, 2024 20:46
@Nailsonseat
Copy link
Contributor Author

Nailsonseat commented Feb 9, 2024

There are two things that are not in this PR:

  • Remove a listing in lost and found
  • Vaccate a room in room vacancy feature

Both of these need credentials of the logged in user to be stored locally on device but were not included in #14 but will be included in #19 along with the token required logic on the frontend aswell. Also this PR has both http and Dio packages, http was used by one of our team member and we have decided to migrate to Dio and the migration will be completed in #19 aswell

@Nailsonseat
Copy link
Contributor Author

Nailsonseat commented Feb 9, 2024

Requesting review @henilp105 @Akshatji800

Copy link
Collaborator

@henilp105 henilp105 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Nailsonseat, looks good to me, minor comments.

@Nailsonseat
Copy link
Contributor Author

Nailsonseat commented Feb 10, 2024

Thank you @henilp105 for the review

  • The image is actually saved to a folder called uploads using the multer file storage, i have moved the multer initilization to the middlewares folder for better readability here
  • The permissions you mentioned were added in the commit for configuring the flutter awesome notifications package, you can expect notifications to be used in PR s for broadcast and chatrooms in the future
  • I have made a .env to include the base url for the backend domain.

Also please ignore the failed workflow build, it is because the .env file is ignored by the gitignore but at the same time it is also mentioned in pubspec.yaml as an asset required by the dotenv package.

I will make a PR soon to edit the build workflow to make a empty dummy .env by touch .env during the workflow build to handle this error.

Requesting review @henilp105

@henilp105 henilp105 merged commit fe2b0d8 into OpenLake:main Feb 10, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants