-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OTP Authentication #14
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t-Insti-App into loginPage" This reverts commit 8602a68, reversing changes made to c3025dc.
Aditya062003
approved these changes
Feb 1, 2024
henilp105
reviewed
Feb 1, 2024
.vscode/easycode.ignore
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add it to .gitignore
.
backend/constants/mailOption.js
Outdated
@@ -1,4 +1,4 @@ | |||
export const senderEmail = 'college@gmail.com'; | |||
export const senderEmail = 'arin.nigam@gmail.com'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please take email as an env variable.
@henilp105 changes are applied. |
henilp105
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User Authentication using OTP
For now email is being sent to the user from my personal gmail by the use of generating app password for the same.
Do you have any suggestions regarding the emails which are sent by personal id. Can we create a different gmail account and do the same till the developing phase.
requesting review @henilp105 @tusharbansal22
Future PR