Messages for room resources

OpenLake · Feb 16, 2024 · 63d7d87 · 63d7d87
1 parent b69898e
commit 63d7d87
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 11 deletions.
diff --git a/backend/constants/messages.js b/backend/constants/messages.js
@@ -36,3 +36,8 @@ export const deleted = "Deleted";
 export const itemNotFound = "Item not found";
 export const itemAdded = "Item added successfully";
 export const itemDeleted = "Item deleted successfully";
+
+// Rooom Vacancy
+export const roomNotFound = "Room not found";
+export const roomUpdated = "Room updated successfully";
+export const roomCreated = "Room created successfully";
diff --git a/backend/resources/rooms/roomListResource.js b/backend/resources/rooms/roomListResource.js
@@ -1,5 +1,6 @@
 import { Router } from "express";
 import Room from "../../models/room.js";
+import * as messages from "../../constants/messages.js";
 const router = Router();
 
 // GET method
@@ -25,16 +26,12 @@ router.post("/", async (req, res) => {
 
     // Save the new room to the database
     await newRoom.save();
-    console.log("Room created successfully");
 
     // Respond with success message
-    res
-      .status(201)
-      .json({ message: "Room created successfully", room: newRoom });
+    res.status(201).json({ message: messages.roomCreated, room: newRoom });
   } catch (error) {
     // Handle errors
-    console.error("Error creating room:", error);
-    res.status(500).json({ error: "Internal server error" });
+    res.status(500).json({ message: messages.internalServerError });
   }
 });
 

diff --git a/backend/resources/rooms/roomResource.js b/backend/resources/rooms/roomResource.js
@@ -1,5 +1,6 @@
 import { Router } from "express";
 import Room from "../../models/room.js";
+import * as messages from "../../constants/messages.js";
 const router = Router();
 
 // PUT method
@@ -9,7 +10,7 @@ router.put("/:id", async (req, res) => {
     const { occupantName, occupantId, vacant } = req.body;
     const room = await Room.findById(id);
     if (!room) {
-      return res.status(404).json({ error: "Room not found" });
+      return res.status(404).json({ message: messages.roomNotFound });
     }
 
     if (vacant) {
@@ -24,11 +25,9 @@ router.put("/:id", async (req, res) => {
 
     await room.save();
 
-    console.log("Room updated successfully");
-    res.json({ message: "Room updated successfully", room });
+    res.json({ message: messages.roomUpdated, room });
   } catch (error) {
-    console.error("Error updating room:", error);
-    res.status(500).json({ error: "Internal server error" });
+    res.status(500).json({ message: messages.internalServerError });
   }
 });