Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] - Mods breaking final form graphics in KH2 #900

Open
tryashtar opened this issue Sep 29, 2023 · 10 comments
Open

[BUG] - Mods breaking final form graphics in KH2 #900

tryashtar opened this issue Sep 29, 2023 · 10 comments
Labels
2/FM Kingdom Hearts 2 and Final Mix Question Further information is requested

Comments

@tryashtar
Copy link
Contributor

OpenKH Build
708

OpenKH Program
Mod Manager

Describe the Bug
When applying certain mods, the graphics of the Final Form aerial finisher are broken. I reported this here, but was asked to report here instead: KH-ReFined/KH-ReFined#133

To Reproduce

  1. Apply this mod to KH2 and build
  2. Load the game and enter final form
  3. Perform a full aerial combo ending with the finisher

Expected behavior
Vanilla finisher graphics (correct):
https://github.com/TopazTK/KH-ReFined/assets/26075577/af33a8dc-1133-408a-bf9a-6e6c8b5d2ffb
image
image

Screenshots
Modded finisher graphics (incorrect):
https://github.com/TopazTK/KH-ReFined/assets/26075577/fbe022f8-1152-4c05-9f44-462548c87ba3
image
image

@Vladabdf Vladabdf added Bug Something is not working as intended, or at all. 2/FM Kingdom Hearts 2 and Final Mix labels Oct 1, 2023
@Vladabdf
Copy link
Collaborator

Vladabdf commented Oct 1, 2023

I have replicated the issue. It only happens in "standard" worlds. The effects play correctly in Timeless River.

I'm not sure it's related to OpenKH though, unless somehow #897 messed things up. I can't imagine any other pull request in recent history would be responsible, as I update my mod manager every time there is an update and did not have this issue as well until 3-4 days ago. I've also been playing on Steam Deck lately and assumed it was a WINE graphic issue, as I also updated my WINE prefix.

@Vladabdf
Copy link
Collaborator

Vladabdf commented Oct 1, 2023

@shananas Any ideas? Have you seen this error?

@TopazTK
Copy link
Collaborator

TopazTK commented Oct 1, 2023

I have replicated the issue. It only happens in "standard" worlds. The effects play correctly in Timeless River.

I'm not sure it's related to OpenKH though, unless somehow #897 messed things up. I can't imagine any other pull request in recent history would be responsible, as I update my mod manager every time there is an update and did not have this issue as well until 3-4 days ago. I've also been playing on Steam Deck lately and assumed it was a WINE graphic issue, as I also updated my WINE prefix.

TR is not patched in the mod in question. That is why.
Also the mod is not the culprit, as it is just a vanilla-like patch.

@Vladabdf Vladabdf added Question Further information is requested and removed Bug Something is not working as intended, or at all. labels Oct 1, 2023
@Vladabdf
Copy link
Collaborator

Vladabdf commented Oct 1, 2023

Just tested without the mod. The effects now play fine. I think it's the mod.

@TopazTK
Copy link
Collaborator

TopazTK commented Oct 1, 2023

Just tested without the mod. The effects now play fine. I think it's the mod.

It isn't. It's the mod manager not being able to build the mod correctly.
Honestly, read the bug report.

@TopazTK
Copy link
Collaborator

TopazTK commented Oct 1, 2023

image
These are the Final Form assets it uses. It builds all .A.US files this way. However, only Final seems affected.

@Vladabdf Vladabdf closed this as completed Oct 1, 2023
@Vladabdf Vladabdf reopened this Oct 1, 2023
@Vladabdf
Copy link
Collaborator

Vladabdf commented Oct 1, 2023

Genuine accident. Whoops

@shananas
Copy link
Collaborator

shananas commented Oct 1, 2023

Pretty sure @Zurphing knows i forget the exact details but you need to patch out of order or something.

https://discord.com/channels/409140906625728532/827187150146764810/1139344668556001352

https://discord.com/channels/409140906625728532/827187150146764810/1139349360090554509

Also why does it provide unedited files vs just the sora hud image since that's what you edit

@shananas
Copy link
Collaborator

shananas commented Oct 1, 2023

So basically without editing the code you just need to patch in a different order than it's extracted.

@shananas
Copy link
Collaborator

shananas commented Oct 1, 2023

Or I'm pretty sure you can do what I did for my hud mods using binarc to only replace the face and seqd since it seems that's all your touching. Should avoid the custom vs vanilla a.us bs or whatever.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2/FM Kingdom Hearts 2 and Final Mix Question Further information is requested
Projects
None yet
Development

No branches or pull requests

4 participants