Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] - Improved listpatch handling for Mods Manager #638

Open
o0DemonBoy0o opened this issue Jul 22, 2022 · 0 comments
Open

[FEATURE] - Improved listpatch handling for Mods Manager #638

o0DemonBoy0o opened this issue Jul 22, 2022 · 0 comments
Labels
Enhancement Request for, or a pull request of, a new feature or enhancement to an existing one. Novice Issue An easy to solve issue, good for newcomers.

Comments

@o0DemonBoy0o
Copy link
Contributor

o0DemonBoy0o commented Jul 22, 2022

listpatch is used to patch certain file types using a yml containing data for what values to change in given entries.
Currently an entry must contain values for everything including data you might not want to change.

Here's an example for am Item entry that edits a keyblade:

Id: 41
  Type: Keyblade
  Flag0: 0
  Flag1: 52
  Rank: C
  StatEntry: 80
  Name: 34242
  Description: 34243
  ShopBuy: 0
  ShopSell: 0
  Command: 0
  Slot: 33
  Picture: 43
  Icon1: 0
  Icon2: 4

If I wanted to only edit the name and description and try using something like this:

- Id: 41
Name: 34250
Description: 34251

It sets the other missing values (Type, Flag0, Flag1, Rank, ect.) to 0 during the build process.

I believe it would be beneficial and allow greater compatibility between mods if instead of using 0 for the default it would instead check to see if the entry ID currently exists and use the values from that as default for anything missing in the listpatch entry.

It would mean something two different mods editing the same entry like this (assuming the very first example is what's being edited):

- Id: 41
  Name: 34250
  Description: 34251
- Id: 41
  Picture: 60
  ShopBuy: 1000
  ShopSell: 100

Would result in everything being put together like so:

Id: 41
  Type: Keyblade
  Flag0: 0
  Flag1: 52
  Rank: C
  StatEntry: 80
  Name: 34250
  Description: 34251
  ShopBuy: 1000
  ShopSell: 100
  Command: 0
  Slot: 33
  Picture: 60
  Icon1: 0
  Icon2: 4

Instead of one listpatch edit completely overwriting the other.

@Vladabdf Vladabdf added Enhancement Request for, or a pull request of, a new feature or enhancement to an existing one. Novice Issue An easy to solve issue, good for newcomers. labels Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Request for, or a pull request of, a new feature or enhancement to an existing one. Novice Issue An easy to solve issue, good for newcomers.
Projects
None yet
Development

No branches or pull requests

2 participants