Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switching to avoid leading zeros in future memberID creations #1150

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

danamlewis
Copy link
Contributor

Description

Previously memberIDs could be created with 0 in the front. Various programs for data processing drop the 0, and then re-using the project memberIDs back in the command line would cause various errors in pulling or processing the data. Immense headaches have ensued for project administrators and data users. This attempts to remove the leading zeros (although it doesn't solve existing memberIDs with leading zeros) from future projectmemberID creation.

Testing

Have not tested but used OpenAI Codex to validate the sanity of this potential solution.

@abitrolly
Copy link
Contributor

Why not switch to strings then?

@danamlewis
Copy link
Contributor Author

@abitrolly I would be happy with achieving the goal of removing the leading zeros in generate project memberID's with whatever way @madprime prefers. I wanted to generate a PR to get this initiative moving, since it's been bothering many project administrators for years.

@madprime please let me know if there's anything else we can do to help move forward this or related solutions. Thanks!

@beaugunderson
Copy link
Member

beaugunderson commented Feb 1, 2023

The code looks good; I'm curious if this implies a secondary step to re-assign user IDs that currently have leading zeroes? If so, this code helps limit the number of reassignments that will happen if we do take that step in the future so it's worth merging now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants