Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Background cleanup of removed entries is disabled even if ChronicleMapBuilder#cleanupRemovedEntries is true #310

Open
glukos opened this issue Jul 30, 2021 · 1 comment
Assignees
Labels

Comments

@glukos
Copy link
Contributor

glukos commented Jul 30, 2021

OldDeletedEntriesCleanupThread:

    @Override
    public void run() {
        throwExceptionIfClosed();

        if (System.currentTimeMillis() - startTime < 1_000)
            return; // cleanup thread stops after this return

        while (!shutdown) {
            // do cleanup in loop

So background cleanup is never performed, which may lead to on-demand cleanup and latency spikes on put() called by a critical thread.

@glukos glukos self-assigned this Jul 30, 2021
@minborg
Copy link
Contributor

minborg commented Jan 3, 2022

Is this easily fixed @glukos ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants