Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix name change function #210

Open
wants to merge 3 commits into
base: 17.0-develop
Choose a base branch
from
Open

Fix name change function #210

wants to merge 3 commits into from

Conversation

kneckinator
Copy link
Collaborator

The name change function added a whitespace at the end of the string, which caused problems that were not easily spotted by a user.

This fix changes the following:

  • Adjusting the name_change function to be more Pythonic, and faster, and make sure there is no trailing space.
  • Adjusting the test for the name_change function to cover the possible scenarios of the function.

@codecov-commenter
Copy link

codecov-commenter commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.68%. Comparing base (2193a08) to head (6ad4a4d).
Report is 1 commits behind head on 17.0-develop.

Additional details and impacted files
@@               Coverage Diff                @@
##           17.0-develop     #210      +/-   ##
================================================
+ Coverage         67.56%   67.68%   +0.12%     
================================================
  Files               166      166              
  Lines              4439     4434       -5     
  Branches            630      540      -90     
================================================
+ Hits               2999     3001       +2     
+ Misses             1346     1345       -1     
+ Partials             94       88       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants